Skip to content

mvp #46: wire ASAP_CONTROLLER_URL env, generalize freshness probe filter - #114

Merged
zzylol merged 1 commit into
mainfrom
mvp-46-controller-url-and-freshness-probe
May 9, 2026
Merged

zzylol merged 1 commit into
mainfrom
mvp-46-controller-url-and-freshness-probe

Conversation

@zzylol

@zzylol zzylol commented May 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • --controller-endpoint now reads ASAP_CONTROLLER_URL env (deploy/docker-compose/base.yml sets it but clap only honored the flag — capability-miss notifications never fired in MVP).
  • Freshness probe cache filter generalized from literal prefix http_freshness_probe_ to substring freshness_probe_. User-extensible probe families now hit the RAM short-circuit without a code change; the three MVP canonical probes (http_freshness_probe_{raw,warm,archive}) still match.

Companion PR

Collector merge processors + controller emit fix: ProjectASAP/ASAPCollector#362

Test plan

  • `cargo build --manifest-path asap-query-engine/Cargo.toml` — clean
  • `cargo test --lib freshness_probe_cache` — 8 passed (includes `is_freshness_probe_matches_three_demo_spellings`)
  • Smoke MVP demo and confirm capability-miss notifications appear in controller logs (with the companion PR merged)

🤖 Generated with Claude Code

`asap-query-engine` ships with `--controller-endpoint` for capability-
miss notifications back to the controller (criterion #2 reverse
channel). The MVP overlay sets `ASAP_CONTROLLER_URL` in
`deploy/docker-compose/base.yml`, but `clap` only read the flag —
not the env var — so the backend silently never notified the
controller. Added `env = "ASAP_CONTROLLER_URL"` to the arg attribute
so the existing compose env var is honored.

Also generalized `routing/freshness_probe_cache.rs` so any metric
whose name *contains* `freshness_probe_` is captured by the RAM
short-circuit (was: literal prefix `http_freshness_probe_`).
User-extensible probe families (e.g. `latency_freshness_probe_*`)
now hit the cache without a code change. The MVP demo's three
canonical probes (`http_freshness_probe_{raw,warm,archive}`) still
match — verified by the existing
`is_freshness_probe_matches_three_demo_spellings` test.

Verification:
- `cargo build --manifest-path asap-query-engine/Cargo.toml`: clean
- `cargo test --lib freshness_probe_cache`: 8 passed

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@zzylol
zzylol merged commit 33c2b42 into main May 9, 2026
@zzylol
zzylol deleted the mvp-46-controller-url-and-freshness-probe branch May 9, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant